Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scix 314 Fix bugs related to visualization page #345

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Scix 314 Fix bugs related to visualization page #345

merged 3 commits into from
Nov 3, 2023

Conversation

shinyichen
Copy link
Member

  • Fix tabs not working
  • Fix undefined error
  • Fix tab that is auto switching back

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #345 (9273ba5) into master (590c81c) will decrease coverage by 0.01%.
The diff coverage is 26.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   48.14%   48.13%   -0.01%     
==========================================
  Files         369      369              
  Lines       37034    37045      +11     
  Branches      511      511              
==========================================
+ Hits        17829    17832       +3     
- Misses      19196    19204       +8     
  Partials        9        9
Files Coverage Δ
src/components/ResultList/Item/Item.tsx 28.04% <0.00%> (ø)
...rc/components/Visualizations/VisualizationTabs.tsx 67.53% <0.00%> (ø)
...izations/Containers/AuthorNetworkPageContainer.tsx 22.22% <33.33%> (+0.12%) ⬆️
.../Panes/NetworkDetails/AuthorNetworkDetailsPane.tsx 28.57% <30.00%> (-0.28%) ⬇️

@shinyichen shinyichen requested a review from thostetler November 2, 2023 18:35
thostetler
thostetler approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinyichen shinyichen merged commit 52142e0 into adsabs:master Nov 3, 2023
3 of 4 checks passed
@shinyichen shinyichen deleted the SCIX-314-viz-page-tabs branch December 6, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thostetler thostetler thostetler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinyichen @thostetler